From e0c8d84b6e7ad6f9f755bb6c4948c904529871bc Mon Sep 17 00:00:00 2001 From: Corentin Ardeois Date: Tue, 15 Oct 2019 14:38:37 -0400 Subject: [PATCH] fix .npmrc file generation When we pass an `auth-token`, a `.npmrc` file is generated but it's value could be invalid The parameter substitution to set a default value on `NPM_` was not working. Github action defines the `NPM_*` environment variables with a null value, but we were setting a default value only if the environment variable was not set at all. --- entrypoint.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/entrypoint.sh b/entrypoint.sh index 5cee675..84cba88 100755 --- a/entrypoint.sh +++ b/entrypoint.sh @@ -4,9 +4,9 @@ set -e if [ -n "$NPM_AUTH_TOKEN" ]; then # Respect NPM_CONFIG_USERCONFIG if it is provided, default to $HOME/.npmrc - NPM_CONFIG_USERCONFIG="${NPM_CONFIG_USERCONFIG-"$HOME/.npmrc"}" - NPM_REGISTRY_URL="${NPM_REGISTRY_URL-registry.npmjs.org}" - NPM_STRICT_SSL="${NPM_STRICT_SSL-true}" + NPM_CONFIG_USERCONFIG="${NPM_CONFIG_USERCONFIG:-"$HOME/.npmrc"}" + NPM_REGISTRY_URL="${NPM_REGISTRY_URL:-registry.npmjs.org}" + NPM_STRICT_SSL="${NPM_STRICT_SSL:-true}" NPM_REGISTRY_SCHEME="https" if ! $NPM_STRICT_SSL then