In Typescript/Javascript an empty string split on newline is going to
produce an array with an empty string.
=> "".split('\n')
[""]
This causes the action to produce a warning, unless `pull-images` is set
to false.
Failed to get dockerfile path for image : Error: The process '/usr/bin/docker' failed with exit code 1
Filtering the list to remove any zero-length strings from the array
solves this issue.
Signed-off-by: Morten Linderud <morten.linderud@nrk.no>
* Make annotating resources optional
* Clarify descriptions
* Update README
* Refactor retrieving pods
* Remove annotating resources check in deploy.ts
* Add resource annotation integration test
* Move resource annotation integration test to seperate file
* Lint code
* Remove temporary debugging statements
* Fix integration test name
* Fix test
* Abstracting out repeated logic between verifyDeployment and verifyService
* Fix formattin
* Fix reference
* Fix test
* Refactor test
* Update ubuntu version to latest on canary SMI test
* Update ubuntu version to latest on canary SMI test
* Make annotating resources optional
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Clarify descriptions
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Update README
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Refactor retrieving pods
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Remove annotating resources check in deploy.ts
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Add resource annotation integration test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Move resource annotation integration test to seperate file
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Lint code
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Remove temporary debugging statements
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix integration test name
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Abstracting out repeated logic between verifyDeployment and verifyService
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix formattin
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix reference
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Refactor test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Update ubuntu version to latest on canary SMI test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
---------
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Check for error from Azure
Move the error check for Azure earlier, so that a well defined error is
thrown on error instead of a JSONSyntax error.
The issue is that when Azure returns an error, like when there's an
issue with the access to the principal used. When this happens, the
stdout field will be an empty string, and the error message will be set.
* Restore check for deserialized exitCode
* changed ubuntu runner
* changed minikube action
* Version formatting
* nonedriveR
* update kube version
* installing conntrack'
* updated other actions
* update bg ingress api version
* prettify
* updated ingress backend for new api version
* Added path type
* prettify
* added logging
* added try catch logic to prevent future failures if annotations fail since failing annotations shouldn't affect users
* added nullcheck
* Added fallback filename if workflow fails to get github filepath due to runner issues
* cleanup
* added oliver's feedback + unit test demonstrating regex glitch and fix
* no longer using blank string for failed regex
* changed ubuntu runner
* changed minikube action
* Version formatting
* nonedriveR
* update kube version
* installing conntrack'
* updated other actions
* update bg ingress api version
* prettify
* updated ingress backend for new api version
* Added path type
* prettify
Jaiveer Katariya