In Typescript/Javascript an empty string split on newline is going to
produce an array with an empty string.
=> "".split('\n')
[""]
This causes the action to produce a warning, unless `pull-images` is set
to false.
Failed to get dockerfile path for image : Error: The process '/usr/bin/docker' failed with exit code 1
Filtering the list to remove any zero-length strings from the array
solves this issue.
Signed-off-by: Morten Linderud <morten.linderud@nrk.no>
* Make annotating resources optional
* Clarify descriptions
* Update README
* Refactor retrieving pods
* Remove annotating resources check in deploy.ts
* Add resource annotation integration test
* Move resource annotation integration test to seperate file
* Lint code
* Remove temporary debugging statements
* Fix integration test name
* Fix test
* Abstracting out repeated logic between verifyDeployment and verifyService
* Fix formattin
* Fix reference
* Fix test
* Refactor test
* Update ubuntu version to latest on canary SMI test
* Update ubuntu version to latest on canary SMI test
* Make annotating resources optional
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Clarify descriptions
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Update README
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Refactor retrieving pods
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Remove annotating resources check in deploy.ts
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Add resource annotation integration test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Move resource annotation integration test to seperate file
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Lint code
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Remove temporary debugging statements
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix integration test name
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Abstracting out repeated logic between verifyDeployment and verifyService
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix formattin
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix reference
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Fix test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Refactor test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Update ubuntu version to latest on canary SMI test
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
---------
Signed-off-by: Bram de Hart <bram.dehart@nsgo.nl>
* Check for error from Azure
Move the error check for Azure earlier, so that a well defined error is
thrown on error instead of a JSONSyntax error.
The issue is that when Azure returns an error, like when there's an
issue with the access to the principal used. When this happens, the
stdout field will be an empty string, and the error message will be set.
* Restore check for deserialized exitCode
* changed ubuntu runner
* changed minikube action
* Version formatting
* nonedriveR
* update kube version
* installing conntrack'
* updated other actions
* update bg ingress api version
* prettify
* updated ingress backend for new api version
* Added path type
* prettify
* added logging
* added try catch logic to prevent future failures if annotations fail since failing annotations shouldn't affect users
* added nullcheck
* Added fallback filename if workflow fails to get github filepath due to runner issues
* cleanup
* added oliver's feedback + unit test demonstrating regex glitch and fix
* no longer using blank string for failed regex
* changed ubuntu runner
* changed minikube action
* Version formatting
* nonedriveR
* update kube version
* installing conntrack'
* updated other actions
* update bg ingress api version
* prettify
* updated ingress backend for new api version
* Added path type
* prettify
* First commit - made manifests for test deployments, made manifests for i tests for other deployment strategies
* broke down blue/green
* added latest tags to test manifests for new tags
* remade tester
* ready to test bgi
* using all but first index of argv
* careless error with dicts
* added test to namespace
* realized i was silencing error
* indexing containers
* keyerror
* logging bc python errors are weird
* expected still string
* parsed args behaving weirdly
* test seems to be working now, applying changes to other YAMLs now
* blue/green ready to test
* oops
* oops
* Added additional labels to check
* hyphen
* Added our annotations
* lol
* added our labels to services too
* nonetype issue'
* nonetype issue'
* narrowing down parameter
* fixed annotations issue with promote
* adding debhug statement to figure out why services aren't getting annotations
* this should fix annotations issue for service
* not sure why this wasn't caught by intellisense
* should be fixed with removing comma but adding logs in case
* added linkerd install
* verification
* upgraded kubernetes version
* removing crds
* proxy option
* Added smi extension
* logging service
* smi svcs also getting labeled now
* matching ts type
* not sure where stable service is going
* remaining svc and deployment should match
* keeping stable service and ts object
* updated tests to reflect keeping ts object
* no green svc after promote
* duh
* lol
* canary work
* canary test ready
* logging for ing, filename for canary
* changed ingress svc key and returning svc files from smi canary deployment
* ts name
* forgot about baseline in first deploy
* *
* *
* smi canary should annotate, fixed cleanup
* typescript issue plus percentage
* forgot to type extra method
* removed cleaned up objects from annotate list
* logging because services aren't getting removed
* moving to try/catch strategy of annotation since deletion can fail silently/with warnings
* moved label to individual
* removing canary service check after promote
* pod ready for testing
* set weights to 1000
* selectors
* *
* percentage
* *
* typing
* mixed up pod and smi
* fixed tests
* prettier
* forgot to remove canary
* cleanup
* Added oliver's feedback + more cleanup
* ncc as dev dependency
* npx
* going back to global ncc install bc npm is being weird
* prettier
* removed unnecessary post step
* Added some tests, not sure what else to try but gonna think of more examples
* forgot some files
* reverted package-lock.json
* Added empty dir test
* Cleaned up some extra spaces
* Add node modules and compiled JavaScript from main
* forgot to actually include functionality
* removed unnecessary files
* Update .gitignore
* Update .gitignore
* Update .gitignore
* thx david
* renamed searchFilesRec
* integrations test fix
* added examples to README
* added note about depth
* added additional note
* removed ticks
* changed version string
* removed conflict on readme
* Added tests for bluegreen helper and resolved issue with ingress not being read correctly, still have to figure out why new services aren't showing up
* resolved services name issue
* looks functional, beginning refactor now
* refactored deploy methods for type error
* Removed refactor comments
* prettier
* implemented Oliver's feedback
* prettier
* added optional chaining operator
* removed refactor comment
Co-authored-by: Jaiveer Katariya <jaiveerkatariya@Jaiveers-MacBook-Pro.local>
Co-authored-by: Oliver King <oking3@uncc.edu>
Co-authored-by: Jaiveer Katariya <jaiveerkatariya@Jaiveers-MBP.lan>
David Gamero